[FIX] Do not require notch frequencies to be parsed as numbers, accommodating multiples #1605
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1605 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 16 16
Lines 1356 1356
=======================================
Hits 1191 1191
Misses 165 165 ☔ View full report in Codecov by Sentry. |
effigies
force-pushed
the
schema/notch-type
branch
from
d28eff0 to
3346056
Compare
effigies
changed the title
|
@adam2392 Are you comfortable with the current wording leaving open the possibility of a more structured recommendation/requirement in the future? |
|
The [low, center, high] is incorrect. The line noise is at 60Hz, so that is where you apply a notch. You sometimes also apply a notch filter to the harmonics at 120 and 180 Hz. Therefore 60Hz should not be referred to as 'low' and 120Hz is definitely not 'center'. |
|
Thank you for the clarification. Is the current wording better? |
effigies
changed the title
|
Yes, thank you! Just a minor suggestion is to say: "If notch filters are applied at multiple frequencies, these frequencies MAY ..." |
effigies
force-pushed
the
schema/notch-type
branch
from
2bfdb3b to
296cebc
Compare
There was a problem hiding this comment.
I am aware that this PR is mostly to get an already existing practice finally incorporated into the spec, but it irks me that this is not very in line with:
Do you think we should RECOMMEND specifying the frequencies as a comma separated list like 60, 120, 240, and clarify that an old method of [60, 120, 240] is DEPRECATED?
Either way, I am approving this, because I am fine with my suggestion being dealt with in a separate PR. Thanks everyone.
|
@Andesha is this something you'd feel comfortable taking a moment to review? |
sappelhoff
changed the title
While schematizing, the
notchcolumn was defined as a number. In the case of iEEG at least, the BEP leads had submitted examples wherenotchtook the form[F1, F2, F3]. This PR recognizes this as existing practice and suggests that curators and tools adopt[F1, F2, ...]for interoperability, but does not require it.cc @bids-standard/raw-electrophys for comment.
Closes bids-standard/bids-examples#395.